update github workflow since github includes firefox & snaps in the default runner image, which causes the build to fail.

going to need a custom runner I guess...might as well only do actions on gitea.

.github/workflows/daily.yaml

@@ -3,7 +3,7 @@ on:
   push:
     branches: [ $default-branch ]
   schedule:
-    - cron: "0 7 * * *"   # daily 07:00
+    - cron: "0 7 * * 1"   # mondays at 07:00
   workflow_dispatch: {}
 
 jobs:

include/fat32/FAT32_SYS.inc

@@ -25,14 +25,9 @@ ALIGN 4, db 0x90
 InitFATDriver:
     __CDECL16_PROC_ENTRY
 .func:
-    mov ax, FAT32_State_t_size
-    push ax                     ; length of fat32_state structure
-    xor ax, ax
-    push ax                     ; init fat32_state with zero
-    mov ax, fat32_state
-    push ax                     ; address of structure
-    call kmemset
-    add sp, 0x6
+
+    __CDECL16_CALL_ARGS fat32_state, 0x0000, FAT32_State_t_size
+    __CDECL16_CALL kmemset, 3
 
 .calc_active_part:
     mov ax, word [partition_offset]            
@@ -111,13 +106,12 @@ SearchFATDIR:
 
     mov bx, fat32_state
     .load_first_dir:
-        mov eax, dword [bx + FAT32_State_t.curr_dir_cluster_32]
-        push dword eax          ; cluster
-        mov ax, dir_buffer
-        push ax                 ; offset
-        xor ax, ax
-        push ax                 ; segment
-        call ReadFATCluster     ; uint8_t ReadFATCluster(uint16_t seg, uint16_t offset, uint32_t cluster)
+
+        ; uint8_t ReadFATCluster(uint16_t seg, uint16_t offset, uint32_t cluster)
+        push dword [bx + FAT32_State_t.curr_dir_cluster_32]          ; cluster
+        push dir_buffer                                              ; offset
+        push 0x0000                                                  ; segment
+        call ReadFATCluster
         add sp, 0x8
 
         mov si, dir_buffer
@@ -127,9 +121,9 @@ SearchFATDIR:
         ; if eax >= 0x0FFFFFF8 then there are no more clusters (end of chain)
         ; if eax == 0x0FFFFFF7 then this is a cluster that is marked as bad
 
-        mov eax, dword [bx + FAT32_State_t.curr_dir_cluster_32]
-        push dword eax
-        call NextCluster        ; uint32_t NextCluster(uint32_t active_cluster);
+        ; uint32_t NextCluster(uint32_t active_cluster);
+        push dword [bx + FAT32_State_t.curr_dir_cluster_32]
+        call NextCluster        
         add sp, 0x4
 
         cmp eax, 0x0fff_fff7
@@ -139,16 +133,14 @@ SearchFATDIR:
 
     .load_next_dir_next_OK:
         ; load 512 bytes of directory entries from data sector
-        mov eax, [bx + FAT32_State_t.curr_dir_cluster_32]
-        push dword eax          ; cluster
 
-        mov ax, dir_buffer    
-        push ax                 ; offset
-
-        xor ax, ax
-        push ax                 ; segment
-        call ReadFATCluster     ; uint8_t ReadFATCluster(uint16_t seg, uint16_t offset, uint32_t cluster)
+        ; uint8_t ReadFATCluster(uint16_t seg, uint16_t offset, uint32_t cluster)
+        push dword [bx + FAT32_State_t.curr_dir_cluster_32] ; cluster   
+        push dir_buffer                                     ; offset
+        push 0x0000                                         ; segment
+        call ReadFATCluster     
         add sp, 0x8
+
     .empty_dir_entry:
         ; check for 0x0 in first byte, if true then there are no more files
         ; if true we did not find the file, we should error here
@@ -219,16 +211,10 @@ NextCluster:
     __CDECL16_CALL_ARGS NextFATCluster_info
     __CDECL16_CALL PrintString, 1
 
-    mov ax, FAT32_NextClusterData_t_size
-    push ax                     ; length
-    xor ax, ax
-    push ax                     ; init with zero
-    mov ax, fat32_nc_data
-    push ax                     ; address of structure
-    call kmemset
-    add sp, 0x6
+    __CDECL16_CALL_ARGS fat32_nc_data, 0x0000, FAT32_NextClusterData_t_size
+    __CDECL16_CALL kmemset, 3
 
-    mov edx, dword [bp + 4]
+    mov edx, dword [bp + 4]                      ; active_cluster
     mov si, fat32_nc_data                        ; instead of push/pop and moving the data back
     mov di, fat32_bpb                            ; load si & di then use xchg
     mov bx, fat32_state
@@ -279,6 +265,7 @@ NextCluster:
     mov ebx, dword [si + FAT32_NextClusterData_t.entry_offset]
     mov si, fat_buffer
     mov eax, dword [bx+si+0]
+    ; BUG: ???
 .endp:
     __CDECL16_PROC_EXIT
     ret

scripts/create-disk.sh

@@ -124,8 +124,11 @@ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
         echo "[2/7] Write DOS partition table (single FAT32 LBA @ 2048)"
         "$SF" --no-reread "$disk_img" < /tmp/pt.sfdisk
 
-        echo "[3/7] Make FAT32 filesystem in partition image"
-        "$MKFS" -v -F32 -s 1 -n 'STEVIAFS' "$part_img"
+        # BUG: the default disk img is 256MiB which mkfs.fat wants to create
+        #      a FAT16 FS by default. it needs to be at least 2GiB to to 'lock out'
+        #      FAT16 as an option. Force FAT32 here, might(?) break some things.
+        echo "[3/7] Make FAT filesystem in partition image"
+        "$MKFS" -F32 -v -n 'STEVIAFS' "$part_img"
 
         echo "[4/7] Patch VBR inside partition image (preserve BPB)"